From: Mike Stepanek (mstepane) <mstepane@cisco.com>
Date: Tue, 23 Jun 2020 19:16:01 +0000 (+0000)
Subject: Merge pull request #2279 in SNORT/snort3 from ~KATHARVE/snort3:checksum_tests to... 
X-Git-Tag: 3.0.2-1~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e754781fe6f236b065f0f95971391b1366419ec5;p=thirdparty%2Fsnort3.git

Merge pull request #2279 in SNORT/snort3 from ~KATHARVE/snort3:checksum_tests to master

Squashed commit of the following:

commit aa5f26c07561becdaf490d0a645ed664508b72b3
Author: Katura Harvey <katharve@cisco.com>
Date:   Mon Jun 22 23:52:43 2020 -0400

    detection: remove checksum drop fixit
---

diff --git a/src/detection/detection_engine.cc b/src/detection/detection_engine.cc
index 14bb09920..95ded1d87 100644
--- a/src/detection/detection_engine.cc
+++ b/src/detection/detection_engine.cc
@@ -576,8 +576,8 @@ bool DetectionEngine::inspect(Packet* p)
         if ( p->ptrs.decode_flags & DECODE_ERR_FLAGS )
         {
             if ( p->context->conf->inline_mode() and
-                // FIXIT-H check specific proto checksum drop flags
-                snort::get_network_policy()->checksum_drops(p->ptrs.decode_flags & DECODE_ERR_CKSUM_ALL) )
+                snort::get_network_policy()->checksum_drops(p->ptrs.decode_flags &
+                    DECODE_ERR_CKSUM_ALL) )
             {
                 p->active->drop_packet(p);
             }