From: Ruili Fang <ruili.fang.98@gmail.com>
Date: Sun, 29 Jan 2023 04:48:24 +0000 (-0500)
Subject: Fix a potential memory leak in crypto/provider_child.c
X-Git-Tag: openssl-3.2.0-alpha1~1349
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e788c772b12eea5ced4ce46619e13acf0e0eb6ba;p=thirdparty%2Fopenssl.git

Fix a potential memory leak in crypto/provider_child.c

Fix issue #20063.
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20163)
---

diff --git a/crypto/provider_child.c b/crypto/provider_child.c
index b1eadd5b19a..176a3a5cb25 100644
--- a/crypto/provider_child.c
+++ b/crypto/provider_child.c
@@ -135,8 +135,10 @@ static int provider_create_child_cb(const OSSL_CORE_HANDLE *prov, void *cbdata)
                                        1)) == NULL)
             goto err;
 
-        if (!ossl_provider_activate(cprov, 0, 0))
+        if (!ossl_provider_activate(cprov, 0, 0)) {
+            ossl_provider_free(cprov);
             goto err;
+        }
 
         if (!ossl_provider_set_child(cprov, prov)
             || !ossl_provider_add_to_store(cprov, NULL, 0)) {