From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Tue, 14 May 2019 22:54:33 +0000 (+1200)
Subject: policy/gp: always close a file (CID 1445119)
X-Git-Tag: samba-4.13.0rc1~75
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e78db8a7ebd01afd3d3128c1221853827d35ab4b;p=thirdparty%2Fsamba.git

policy/gp: always close a file (CID 1445119)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source4/lib/policy/gp_filesys.c b/source4/lib/policy/gp_filesys.c
index 5a300f134fe..eaae5b79230 100644
--- a/source4/lib/policy/gp_filesys.c
+++ b/source4/lib/policy/gp_filesys.c
@@ -486,6 +486,7 @@ static NTSTATUS push_recursive (struct gp_context *gp_ctx, const char *local_pat
 					DBG_ERR("read failed with errno %s\n",
 						strerror(errno));
 					status = NT_STATUS_UNSUCCESSFUL;
+					close(local_fd);
 					goto done;
 				}
 				smbcli_write(gp_ctx->cli->tree, remote_fd, 0,