From: Volker Lendecke <vl@samba.org>
Date: Fri, 17 May 2024 10:32:20 +0000 (+0200)
Subject: libsmb: Use SMB2_0_INFO_ constants instead of magic numbers
X-Git-Tag: tdb-1.4.11~614
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e79698c4be6a092ec2fb32037040201cd583aeee;p=thirdparty%2Fsamba.git

libsmb: Use SMB2_0_INFO_ constants instead of magic numbers

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
index 099ba44597c..7f44435963f 100644
--- a/source3/libsmb/cli_smb2_fnum.c
+++ b/source3/libsmb/cli_smb2_fnum.c
@@ -2431,7 +2431,7 @@ NTSTATUS cli_smb2_setatr(struct cli_state *cli,
 	return cli_smb2_setpathinfo(
 		cli,
 		name,
-		1,			     /* in_info_type */
+		SMB2_0_INFO_FILE,	     /* in_info_type */
 		FSCC_FILE_BASIC_INFORMATION, /* in_file_info_class */
 		&inbuf);
 }
@@ -2480,7 +2480,7 @@ NTSTATUS cli_smb2_setattrE(struct cli_state *cli,
 	status = cli_smb2_set_info_fnum(
 		cli,
 		fnum,
-		1,			     /* in_info_type */
+		SMB2_0_INFO_FILE,	     /* in_info_type */
 		FSCC_FILE_BASIC_INFORMATION, /* in_file_info_class */
 		&inbuf,			     /* in_input_buffer */
 		0);			     /* in_additional_info */
@@ -3149,7 +3149,7 @@ static struct tevent_req *cli_smb2_rename_fnum_send(
 		ev,			      /* ev */
 		cli,			      /* cli */
 		fnum,			      /* fnum */
-		1,			      /* in_info_type */
+		SMB2_0_INFO_FILE,	      /* in_info_type */
 		FSCC_FILE_RENAME_INFORMATION, /* in_file_info_class */
 		&state->inbuf,		      /* in_input_buffer */
 		0);			      /* in_additional_info */
@@ -3365,7 +3365,7 @@ NTSTATUS cli_smb2_set_ea_fnum(struct cli_state *cli,
 	status = cli_smb2_set_info_fnum(
 		cli,
 		fnum,
-		1,			       /* in_info_type */
+		SMB2_0_INFO_FILE,	       /* in_info_type */
 		FSCC_FILE_FULL_EA_INFORMATION, /* in_file_info_class */
 		&inbuf,			       /* in_input_buffer */
 		0);			       /* in_additional_info */
@@ -3474,7 +3474,7 @@ NTSTATUS cli_smb2_get_ea_list_path(struct cli_state *cli,
 	status = cli_smb2_query_info_fnum(
 		cli,
 		fnum,
-		1,			       /* in_info_type */
+		SMB2_0_INFO_FILE,	       /* in_info_type */
 		FSCC_FILE_FULL_EA_INFORMATION, /* in_file_info_class */
 		0xFFFF,			       /* in_max_output_length */
 		NULL,			       /* in_input_buffer */
@@ -3726,7 +3726,7 @@ NTSTATUS cli_smb2_get_fs_quota_info(struct cli_state *cli,
 	status = cli_smb2_query_info_fnum(
 		cli,
 		quota_fnum,
-		2,			   /* in_info_type */
+		SMB2_0_INFO_FILESYSTEM,	   /* in_info_type */
 		FSCC_FS_QUOTA_INFORMATION, /* in_file_info_class */
 		0xFFFF,			   /* in_max_output_length */
 		NULL,			   /* in_input_buffer */
@@ -3814,7 +3814,7 @@ NTSTATUS cli_smb2_set_fs_quota_info(struct cli_state *cli,
 	status = cli_smb2_set_info_fnum(
 		cli,
 		quota_fnum,
-		2,			   /* in_info_type */
+		SMB2_0_INFO_FILESYSTEM,	   /* in_info_type */
 		FSCC_FS_QUOTA_INFORMATION, /* in_file_info_class */
 		&inbuf,			   /* in_input_buffer */
 		0);			   /* in_additional_info */
@@ -4722,7 +4722,7 @@ NTSTATUS cli_smb2_ftruncate(struct cli_state *cli,
 	status = cli_smb2_set_info_fnum(
 		cli,
 		fnum,
-		1,				   /* in_info_type */
+		SMB2_0_INFO_FILE,		   /* in_info_type */
 		FSCC_FILE_END_OF_FILE_INFORMATION, /* in_file_info_class */
 		&inbuf,				   /* in_input_buffer */
 		0);
diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index edbc21bc3c3..7732cb91279 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -2026,7 +2026,7 @@ static void cli_smb2_hardlink_opened(struct tevent_req *subreq)
 		state->ev,
 		state->cli,
 		state->fnum_src,
-		1,			    /* in_info_type */
+		SMB2_0_INFO_FILE,	    /* in_info_type */
 		FSCC_FILE_LINK_INFORMATION, /* in_file_info_class */
 		&inbuf,
 		0); /* in_additional_info */
diff --git a/source3/libsmb/clirap.c b/source3/libsmb/clirap.c
index b25f6832273..ffc643625c9 100644
--- a/source3/libsmb/clirap.c
+++ b/source3/libsmb/clirap.c
@@ -626,7 +626,7 @@ NTSTATUS cli_setpathinfo_ext(struct cli_state *cli, const char *fname,
 		 */
 		return cli_smb2_setpathinfo(cli,
 					    fname,
-					    1, /* SMB2_SETINFO_FILE */
+					    SMB2_0_INFO_FILE,
 					    FSCC_FILE_BASIC_INFORMATION,
 					    &in_data);
 	}