From: Jim Meyering <meyering@redhat.com>
Date: Wed, 1 Jun 2011 11:48:12 +0000 (+0200)
Subject: tail: fix an inconsequential bug spotted by coverity
X-Git-Tag: v8.13~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e7b4bf4b57efb699c87f03c1173d812ea34cb618;p=thirdparty%2Fcoreutils.git

tail: fix an inconsequential bug spotted by coverity

* src/tail.c (start_bytes): Increase *READ_POS (not READ_POS)
by the number of bytes read.  This is a real bug that happens
to have no consequence in practice.  First, this code is exercised
only when tailing-forever a non-regular file by bytes, and with a
start-relative offset, e.g., "mkfifo f; tail -f -c +3 f", but even
then, the invalid READ_POS value does not influence how tail works.
It is stored in the File_spec.size member, but that member is not
used at all in tail_forever_inotify, and in tail_forever, it is
used only when the File_spec refers to a regular file.
---

diff --git a/src/tail.c b/src/tail.c
index 714e278e45..f315776331 100644
--- a/src/tail.c
+++ b/src/tail.c
@@ -818,7 +818,7 @@ start_bytes (const char *pretty_filename, int fd, uintmax_t n_bytes,
           error (0, errno, _("error reading %s"), quote (pretty_filename));
           return 1;
         }
-      read_pos += bytes_read;
+      *read_pos += bytes_read;
       if (bytes_read <= n_bytes)
         n_bytes -= bytes_read;
       else