From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sat, 27 Aug 2011 12:34:04 +0000 (-0600)
Subject: Polished unused code.
X-Git-Tag: SQUID_3_1_15~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8004619989bde737c0e3392fe3d6b5725b8a002;p=thirdparty%2Fsquid.git

Polished unused code.

The unused dlopen() call is actually useful to enable when lt_dlopen() reports
"file not found" errors for loadable modules that do exist but that Libtool
cannot load successfully due to undefined symbols or other errors.

This inability to correctly report a library loading error is a long-standing
Libtool bug, stemming from Libtool's desire to try and load several
differently named library files until one succeeds, losing true error
information in the process.
---

diff --git a/src/LoadableModule.cc b/src/LoadableModule.cc
index faf96c5411..2a0f1202a3 100644
--- a/src/LoadableModule.cc
+++ b/src/LoadableModule.cc
@@ -69,7 +69,7 @@ void *LoadableModule::openModule(int mode)
 #	if XSTD_USE_LIBLTDL
     return lt_dlopen(theName.termedBuf());
 #	else
-    return dlopen(theName.c_str(),
+    return dlopen(theName.termedBuf(),
                   mode == lmNow ? RTLD_NOW : RTLD_LAZY);
 #	endif
 }