From: Michal Privoznik Date: Wed, 17 Jul 2013 06:07:20 +0000 (+0200) Subject: qemuDomainGetSchedulerType: Prefer qemuDomObjFromDomain X-Git-Tag: v1.1.1-rc1~100 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e80e07f65734ed4c1a487f6f9ddc06c84dee4787;p=thirdparty%2Flibvirt.git qemuDomainGetSchedulerType: Prefer qemuDomObjFromDomain In all qemu APIs we tend to prefer qemuDomObjFromDomain over virDomainObjListFindByUUID. But somehow the qemuDomainGetSchedulerType left unattended. --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7cad120067..b7b066dcce 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7545,18 +7545,14 @@ cleanup: static char *qemuDomainGetSchedulerType(virDomainPtr dom, int *nparams) { - virQEMUDriverPtr driver = dom->conn->privateData; char *ret = NULL; int rc; virDomainObjPtr vm = NULL; qemuDomainObjPrivatePtr priv; - vm = virDomainObjListFindByUUID(driver->domains, dom->uuid); - if (vm == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("No such domain %s"), dom->uuid); + if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; - } + priv = vm->privateData; if (virDomainGetSchedulerTypeEnsureACL(dom->conn, vm->def) < 0)