From: Jeremy Allison <jra@samba.org> 
Date: Wed, 2 Sep 1998 17:23:41 +0000 (+0000)
Subject: Fix for PR#9497 - not waiting for child.
X-Git-Tag: samba-2.0.0alpha3~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e817d836bba3aaf0f732d66bc5a4383a7f7005db;p=thirdparty%2Fsamba.git

Fix for PR#9497 - not waiting for child.
Jeremy.
---

diff --git a/source/smbd/chgpasswd.c b/source/smbd/chgpasswd.c
index aebdde6d34c..c9478166c4a 100644
--- a/source/smbd/chgpasswd.c
+++ b/source/smbd/chgpasswd.c
@@ -319,12 +319,14 @@ BOOL chat_with_program(char *passwordprogram,char *name,char *chatsequence, BOOL
       kill(pid, SIGKILL); /* be sure to end this process */
     }
 
-    close(master);
-
     if ((wpid = sys_waitpid(pid, &wstat, 0)) < 0) {
       DEBUG(3,("The process is no longer waiting!\n\n"));
+      close(master);
       return(False);
     }
+
+    close(master);
+
     if (pid != wpid) {
       DEBUG(3,("We were waiting for the wrong process ID\n"));	
       return(False);