From: Viktor Szakats Date: Mon, 19 Jan 2026 22:21:30 +0000 (+0100) Subject: tool_getparam: avoid `-Wcomma` with Apple clang in C89 mode X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8189c44201db6bff987a8771df90f853d93dec5;p=thirdparty%2Fcurl.git tool_getparam: avoid `-Wcomma` with Apple clang in C89 mode Seen with Apple clang 17: ``` curl/src/tool_getparam.c:3062:12: warning: possible misuse of comma operator here [-Wcomma] 3062 | for(i = 1, stillflags = TRUE; i < argc && !result; i++) { | ^ curl/src/tool_getparam.c:3062:7: note: cast expression to void to silence warning 3062 | for(i = 1, stillflags = TRUE; i < argc && !result; i++) { | ^~~~~ | (void)( ) ``` Closes #20362 --- diff --git a/src/tool_getparam.c b/src/tool_getparam.c index 56f4d58f73..54b209869d 100644 --- a/src/tool_getparam.c +++ b/src/tool_getparam.c @@ -3059,7 +3059,8 @@ ParameterError parse_args(int argc, argv_item_t argv[]) ParameterError result = PARAM_OK; struct OperationConfig *config = global->first; - for(i = 1, stillflags = TRUE; i < argc && !result; i++) { + stillflags = TRUE; + for(i = 1; i < argc && !result; i++) { orig_opt = convert_tchar_to_UTF8(argv[i]); if(!orig_opt) return PARAM_NO_MEM;