From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 30 Nov 2011 17:16:08 +0000 (-0500)
Subject: Resolve a resource leak in test_util_split_lines
X-Git-Tag: tor-0.2.3.9-alpha~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e83862a0ff7be42f5cbcb35c20b0405ca5bb27fd;p=thirdparty%2Ftor.git

Resolve a resource leak in test_util_split_lines

Fixes coverity CID # 488
---

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 93f11cd208..c762a8d7b3 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -1660,7 +1660,7 @@ test_util_split_lines(void *ptr)
 
   int i, j;
   char *orig_line;
-  smartlist_t *sl;
+  smartlist_t *sl=NULL;
 
   (void)ptr;
 
@@ -1689,10 +1689,12 @@ test_util_split_lines(void *ptr)
     tt_assert(tests[i].split_line[j] == NULL);
     tor_free(orig_line);
     smartlist_free(sl);
+    sl = NULL;
   }
 
  done:
-  ;
+  tor_free(orig_line);
+  smartlist_free(sl);
 }
 
 static void