From: Julian Seward Date: Sat, 17 Nov 2007 21:31:48 +0000 (+0000) Subject: Don't pollute the XML output if the program terminates with a signal, X-Git-Tag: svn/VALGRIND_3_3_0~115 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e83bc0c1809ede175ec7647c665e550c7ef4b7a3;p=thirdparty%2Fvalgrind.git Don't pollute the XML output if the program terminates with a signal, and for a couple of other minor warnings. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7176 --- diff --git a/coregrind/m_signals.c b/coregrind/m_signals.c index bb32628456..0ab607cab7 100644 --- a/coregrind/m_signals.c +++ b/coregrind/m_signals.c @@ -822,7 +822,7 @@ SysRes VG_(do_sys_sigaction) ( Int signo, return VG_(mk_SysRes_Success)( 0 ); bad_signo: - if (VG_(showing_core_errors)()) { + if (VG_(showing_core_errors)() && !VG_(clo_xml)) { VG_(message)(Vg_UserMsg, "Warning: bad signal number %d in sigaction()", signo); @@ -830,7 +830,7 @@ SysRes VG_(do_sys_sigaction) ( Int signo, return VG_(mk_SysRes_Error)( VKI_EINVAL ); bad_signo_reserved: - if (VG_(showing_core_errors)()) { + if (VG_(showing_core_errors)() && !VG_(clo_xml)) { VG_(message)(Vg_UserMsg, "Warning: ignored attempt to set %s handler in sigaction();", signame(signo)); @@ -841,7 +841,7 @@ SysRes VG_(do_sys_sigaction) ( Int signo, return VG_(mk_SysRes_Error)( VKI_EINVAL ); bad_sigkill_or_sigstop: - if (VG_(showing_core_errors)()) { + if (VG_(showing_core_errors)() && !VG_(clo_xml)) { VG_(message)(Vg_UserMsg, "Warning: ignored attempt to set %s handler in sigaction();", signame(signo)); @@ -1206,7 +1206,8 @@ static void default_action(const vki_siginfo_t *info, ThreadId tid) core = False; } - if (VG_(clo_verbosity) > 1 || (could_core && info->si_code > VKI_SI_USER)) { + if ( (VG_(clo_verbosity) > 1 || (could_core && info->si_code > VKI_SI_USER)) + && !VG_(clo_xml) ) { VG_(message)(Vg_UserMsg, ""); VG_(message)(Vg_UserMsg, "Process terminating with default action of signal %d (%s)%s",