From: Joshua Morris <joshua.morris@deswik.com>
Date: Thu, 8 Jun 2023 22:46:26 +0000 (+1000)
Subject: remove __getitem__ method from ClauseList
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e84f217054b797361168480035e5e8f563f82409;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

remove __getitem__ method from ClauseList
---

diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py
index 8c77f1c585..ac16904279 100644
--- a/lib/sqlalchemy/dialects/mysql/base.py
+++ b/lib/sqlalchemy/dialects/mysql/base.py
@@ -1210,13 +1210,11 @@ class MySQLCompiler(compiler.SQLCompiler):
 
     def visit_string_agg_func(self, fn, **kw):
         if len(fn.clauses) > 1:
-            clause = ", ".join(
-                elem._compiler_dispatch(self, **kw) for elem in fn.clauses[:-1]
-            )
-            return "group_concat(%s SEPARATOR %s)" % (
-                clause,
-                fn.clauses[-1]._compiler_dispatch(self, **kw),
-            )
+            clauses = [
+                elem._compiler_dispatch(self, **kw) for elem in fn.clauses
+            ]
+            clause = ", ".join(clauses[:-1])
+            return "group_concat(%s SEPARATOR %s)" % (clause, clauses[-1])
         else:
             return "group_concat%s" % self.function_argspec(fn)
 
diff --git a/lib/sqlalchemy/sql/elements.py b/lib/sqlalchemy/sql/elements.py
index ad5fcde1ae..ba074db80c 100644
--- a/lib/sqlalchemy/sql/elements.py
+++ b/lib/sqlalchemy/sql/elements.py
@@ -2766,9 +2766,6 @@ class ClauseList(
         self._is_implicitly_boolean = False
         return self
 
-    def __getitem__(self, item) -> ColumnElement[Any]:
-        return self.clauses[item]
-
     def __iter__(self) -> Iterator[ColumnElement[Any]]:
         return iter(self.clauses)