From: Pádraig Brady
Date: Tue, 8 Sep 2009 09:00:01 +0000 (+0100) Subject: tests: tail-2/assert: reduce risk of race condition X-Git-Tag: v7.6~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8591fd39f70932d40e9a6ddd4e607a89a3162f2;p=thirdparty%2Fcoreutils.git tests: tail-2/assert: reduce risk of race condition * tests/tail2/assert: This reverts commit be853120, 25-08-2009, "tests: tail-2/assert: avoid risk of race condition" kill -0 doesn't send a signal and so will only confirm that the background process was forked, which we know already because we have its pid. --- diff --git a/tests/tail-2/assert b/tests/tail-2/assert index 623c3684f2..416f206a19 100755 --- a/tests/tail-2/assert +++ b/tests/tail-2/assert @@ -42,13 +42,9 @@ tail_pid=$! echo sleeping for 7 seconds... -# Wait for the backgrounded `tail' to start before removing foo. +# Give the backgrounded `tail' a chance to start before removing foo. # Otherwise, without --retry, tail wouldn't try to open `foo' again. -while :; do - env kill -0 $tail_pid && break - echo sleep .1 - sleep .1 -done +sleep 1 rm -f foo sleep 6