From: Noel Power Date: Wed, 14 Aug 2019 13:28:16 +0000 (+0100) Subject: s3/libsmb: clang: Fix 'Value stored to 'p' is never read' warning X-Git-Tag: tevent-0.10.1~131 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e874cc909a7f12286ae2514ceb063193469a8946;p=thirdparty%2Fsamba.git s3/libsmb: clang: Fix 'Value stored to 'p' is never read' warning Fixes: source3/libsmb/clirap2.c:1197:4: warning: Value stored to 'p' is never read <--[clang] p += rap_getstringp(frame, ^ ~~~~~~~~~~~~~~~~~~~~~ source3/libsmb/clirap2.c:1525:5: warning: Value stored to 'p' is never read <--[clang] p += rap_getstring(frame, ^ ~~~~~~~~~~~~~~~~~~~~ source3/libsmb/clirap2.c:2358:3: warning: Value stored to 'p' is never read <--[clang] p += WORDSIZE; /* skip rsize */ ^ ~~~~~~~~ source3/libsmb/clirap2.c:2380:3: warning: Value stored to 'p' is never read <--[clang] p += rap_getstringp(frame, ^ ~~~~~~~~~~~~~~~~~~~~~ 4 warnings generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/source3/libsmb/clirap2.c b/source3/libsmb/clirap2.c index 3dd299c1cb3..fdff34fcf64 100644 --- a/source3/libsmb/clirap2.c +++ b/source3/libsmb/clirap2.c @@ -1194,7 +1194,7 @@ int cli_NetFileGetInfo(struct cli_state *cli, uint32_t file_id, void (*fn)(const rdata, converter, endp); - p += rap_getstringp(frame, + rap_getstringp(frame, p, &fuser, rdata, @@ -1522,7 +1522,7 @@ bool cli_get_pdc_name(struct cli_state *cli, const char *workgroup, char **pdc_n if (count > 0) { TALLOC_CTX *frame = talloc_stackframe(); char *dcname; - p += rap_getstring(frame, + rap_getstring(frame, p, &dcname, endp); @@ -2355,7 +2355,6 @@ int cli_NetSessionGetInfo(struct cli_state *cli, const char *workstation, p = rparam + WORDSIZE; GETWORD(p, converter,endp); - p += WORDSIZE; /* skip rsize */ p = rdata; endp = rdata + rdrcnt; @@ -2377,7 +2376,7 @@ int cli_NetSessionGetInfo(struct cli_state *cli, const char *workstation, GETDWORD(p, sess_time, endp); GETDWORD(p, idle_time, endp); GETDWORD(p, user_flags, endp); - p += rap_getstringp(frame, + rap_getstringp(frame, p, &clitype_name, rdata,