From: Christian Hesse <mail@eworm.de>
Date: Fri, 30 Sep 2022 08:26:43 +0000 (+0200)
Subject: systemctl: color ignored exit status in yellow, not red
X-Git-Tag: v252-rc1~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e879434df550c6dcfc02f23e613f4dda7f741089;p=thirdparty%2Fsystemd.git

systemctl: color ignored exit status in yellow, not red

If the executable path is prefixed with "-", an exit code of the command
normally considered a failure (i.e. non-zero exit status or abnormal exit
due to signal) is recorded, but has no further effect and is considered
equivalent to success.

Let's honor this with `systemctl status`, and color ignored exit status
in yellow, not red.
---

diff --git a/src/systemctl/systemctl-show.c b/src/systemctl/systemctl-show.c
index beeffda316c..4c7094678c9 100644
--- a/src/systemctl/systemctl-show.c
+++ b/src/systemctl/systemctl-show.c
@@ -584,7 +584,7 @@ static void print_status_info(
 
                 good = is_clean_exit(p->code, p->status, EXIT_CLEAN_DAEMON, NULL);
                 if (!good) {
-                        on = ansi_highlight_red();
+                        on = p->ignore ? ansi_highlight_yellow() : ansi_highlight_red();
                         off = ansi_normal();
                 } else
                         on = off = "";