From: Brian Foster Date: Fri, 5 Oct 2018 02:36:10 +0000 (-0500) Subject: xfs: remove unused deferred ops committed field X-Git-Tag: v4.19.0-rc0~39 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e89bdff4fd58dd5b52c75a549b53ea74fd45a5c6;p=thirdparty%2Fxfsprogs-dev.git xfs: remove unused deferred ops committed field Source kernel commit: 83200bfac6082a46cc962366478d050052e50450 dop_committed is set when deferred item processing rolls the transaction at least once, but is only ever accessed in tracepoints. The transaction roll/commit events are already available via independent tracepoints, so remove the otherwise unused field. Signed-off-by: Brian Foster Reviewed-by: Christoph Hellwig Reviewed-by: Bill O'Donnell Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Signed-off-by: Eric Sandeen --- diff --git a/libxfs/xfs_defer.c b/libxfs/xfs_defer.c index bdc6db463..ba73b8901 100644 --- a/libxfs/xfs_defer.c +++ b/libxfs/xfs_defer.c @@ -249,7 +249,6 @@ xfs_defer_trans_roll( xfs_defer_trans_abort(*tp, dop, error); return error; } - dop->dop_committed = true; /* Rejoin the joined inodes. */ for (i = 0; i < XFS_DEFER_OPS_NR_INODES && dop->dop_inodes[i]; i++) diff --git a/libxfs/xfs_defer.h b/libxfs/xfs_defer.h index c17c9deda..58c979c9f 100644 --- a/libxfs/xfs_defer.h +++ b/libxfs/xfs_defer.h @@ -49,7 +49,6 @@ enum xfs_defer_ops_type { #define XFS_DEFER_OPS_NR_BUFS 2 /* join up to two buffers */ struct xfs_defer_ops { - bool dop_committed; /* did any trans commit? */ bool dop_low; /* alloc in low mode */ struct list_head dop_intake; /* unlogged pending work */ struct list_head dop_pending; /* logged pending work */