From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 11 Jun 2021 08:08:37 +0000 (+0200)
Subject: bhyveConnectDomainXMLToNative: Fix memory leak in incorrect virCommandToString usage
X-Git-Tag: v7.5.0-rc1~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8a396682be807d8c31ef58cd9d2a3020e0b37be;p=thirdparty%2Flibvirt.git

bhyveConnectDomainXMLToNative: Fix memory leak in incorrect virCommandToString usage

virCommandToString returns an allocated buffer, so using it directly as
argument of virBufferAdd which doesn't consume the string causes it to
be leaked. Switch to virBufferToStringBuf since we are already using a
buffer.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 0fddf9533b..516490f6cd 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -723,14 +723,14 @@ bhyveConnectDomainXMLToNative(virConnectPtr conn,
                                                     "<device.map>", NULL)))
             goto cleanup;
 
-        virBufferAdd(&buf, virCommandToString(loadcmd, false), -1);
+        virCommandToStringBuf(loadcmd, &buf, false, false);
         virBufferAddChar(&buf, '\n');
     }
 
     if (!(cmd = virBhyveProcessBuildBhyveCmd(privconn, def, true)))
         goto cleanup;
 
-    virBufferAdd(&buf, virCommandToString(cmd, false), -1);
+    virCommandToStringBuf(cmd, &buf, false, false);
 
     ret = virBufferContentAndReset(&buf);