From: Greg Hudson <ghudson@mit.edu>
Date: Tue, 24 Sep 2019 05:47:18 +0000 (-0400)
Subject: Follow-up on krb5_gss_duplicate_name() null check
X-Git-Tag: krb5-1.18-beta1~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8a932e2bdf822c655fa8faebd23f3f0fd756dab;p=thirdparty%2Fkrb5.git

Follow-up on krb5_gss_duplicate_name() null check

Commit 9fd7bc179f0bd74fc83c1edf0247dcfd87fc73e6 missed a second null
check, so the forward-null defect was not squashed.  Remove that one
as well.
---

diff --git a/src/lib/gssapi/krb5/duplicate_name.c b/src/lib/gssapi/krb5/duplicate_name.c
index ea53e9c0d6..670b2b509f 100644
--- a/src/lib/gssapi/krb5/duplicate_name.c
+++ b/src/lib/gssapi/krb5/duplicate_name.c
@@ -38,8 +38,7 @@ krb5_gss_duplicate_name(OM_uint32 *minor_status, const gss_name_t input_name,
 
     code = krb5_gss_init_context(&context);
     if (code) {
-        if (minor_status)
-            *minor_status = code;
+        *minor_status = code;
         return GSS_S_FAILURE;
     }