From: Volker Lendecke <vl@samba.org>
Date: Tue, 3 Sep 2019 08:38:35 +0000 (+0200)
Subject: samr: Fix CID 1453463: Null pointer dereferences (NULL_RETURNS)
X-Git-Tag: talloc-2.3.1~990
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8ac8a357aec218807f1b750c004bc2f88aa4b08;p=thirdparty%2Fsamba.git

samr: Fix CID 1453463: Null pointer dereferences (NULL_RETURNS)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index 29e1bd4608f..70f914bf14c 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -1649,6 +1649,11 @@ static int user_iterate_callback(struct ldb_request *req,
 
 		ent = &(ac->entries[ac->num_entries++]);
 		val = ldb_msg_find_ldb_val(msg, "samaccountname");
+		if (val == NULL) {
+			DBG_WARNING("samaccountname attribute not found\n");
+			ret = ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+			break;
+		}
 		ent->name.string = talloc_steal(ac->entries,
 					        (char *)val->data);
 		ent->idx = rid;