From: Julian Seward <jseward@acm.org>
Date: Thu, 29 Sep 2011 17:29:53 +0000 (+0000)
Subject: Compile everything with -fno-builtin, so as to disable LLVM's
X-Git-Tag: svn/VALGRIND_3_7_0~172
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8ce3f7abbd15f3332c5a8074b7c83b03710b4da;p=thirdparty%2Fvalgrind.git

Compile everything with -fno-builtin, so as to disable LLVM's
idiom-recognition optimisation.  This identifies memset-style
loops and turns them into calls to memset, which in this case
leads to infinite recursion because it does this transformations
in VG_(memset), which is called from memset(), which we also define.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@12065
---

diff --git a/Makefile.all.am b/Makefile.all.am
index 513b810b45..fe6fccd201 100644
--- a/Makefile.all.am
+++ b/Makefile.all.am
@@ -80,6 +80,8 @@ clean-noinst_DSYMS:
 
 # Baseline flags for all compilations.  Aim here is to maximise
 # performance and get whatever useful warnings we can out of gcc.
+# -fno-builtin is important for defeating LLVM's idiom recognition
+# that somehow causes VG_(memset) to get into infinite recursion.
 AM_CFLAGS_BASE = \
 	-O2 -g \
 	-Wall \
@@ -89,7 +91,8 @@ AM_CFLAGS_BASE = \
 	-Wstrict-prototypes \
 	-Wmissing-declarations \
 	@FLAG_W_NO_FORMAT_ZERO_LENGTH@ \
-	-fno-strict-aliasing
+	-fno-strict-aliasing \
+	-fno-builtin
 
 # These flags are used for building the preload shared objects.
 # The aim is to give reasonable performance but also to have good
@@ -97,9 +100,11 @@ AM_CFLAGS_BASE = \
 # into (and through) the preloads.
 if VGCONF_OS_IS_DARWIN
 AM_CFLAGS_PIC = -dynamic -O -g -fno-omit-frame-pointer -fno-strict-aliasing \
-		-mno-dynamic-no-pic -fpic -fPIC
+		-mno-dynamic-no-pic -fpic -fPIC \
+		-fno-builtin
 else
-AM_CFLAGS_PIC = -fpic -O -g -fno-omit-frame-pointer -fno-strict-aliasing
+AM_CFLAGS_PIC = -fpic -O -g -fno-omit-frame-pointer -fno-strict-aliasing \
+		-fno-builtin
 endif