From: David Rowley Date: Tue, 6 Jan 2026 02:16:14 +0000 (+1300) Subject: Fix misleading comment for GetOperatorFromCompareType X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e8d4e94a47ea0f02e180208ec7daf03bdd2f751e;p=thirdparty%2Fpostgresql.git Fix misleading comment for GetOperatorFromCompareType The comment claimed *strat got set to InvalidStrategy when the function lookup fails. This isn't true; an ERROR is raised when that happens. Author: Paul A Jungwirth Reviewed-by: Neil Chen Discussion: https://postgr.es/m/CA+renyXOrjLacP_nhqEQUf2W+ZCoY2q5kpQCfG05vQVYzr8b9w@mail.gmail.com Backpatch-through: 18 --- diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 755dc00c86f..0a7b6f18fa2 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -2460,8 +2460,8 @@ GetDefaultOpClass(Oid type_id, Oid am_id) * Finds an operator from a CompareType. This is used for temporal index * constraints (and other temporal features) to look up equality and overlaps * operators. We ask an opclass support function to translate from the - * compare type to the internal strategy numbers. If the function isn't - * defined or it gives no result, we set *strat to InvalidStrategy. + * compare type to the internal strategy numbers. Raises ERROR on search + * failure. */ void GetOperatorFromCompareType(Oid opclass, Oid rhstype, CompareType cmptype,