From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Thu, 1 Dec 2022 19:54:02 +0000 (+0100)
Subject: imap: cmd-urlfetch - Prevent assertion failure upon error in urlfetch callback.
X-Git-Tag: 2.4.0~2972
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9012d8e9a2ed65af62686e4690349be1c521a42;p=thirdparty%2Fdovecot%2Fcore.git

imap: cmd-urlfetch - Prevent assertion failure upon error in urlfetch callback.

Panic was:

Panic: file imap-client.c: line 988 (client_command_free): assertion failed: (!cmd->executing)
---

diff --git a/src/imap/cmd-urlfetch.c b/src/imap/cmd-urlfetch.c
index 8508a0145d..8241d99b89 100644
--- a/src/imap/cmd-urlfetch.c
+++ b/src/imap/cmd-urlfetch.c
@@ -284,7 +284,8 @@ cmd_urlfetch_url_callback(struct imap_urlauth_fetch_reply *reply,
 	if ((last && cmd->state == CLIENT_COMMAND_STATE_WAIT_EXTERNAL) ||
 	    ret < 0) {
 		cmd_urlfetch_finish(cmd);
-		client_command_free(&cmd);
+		if (!cmd->executing)
+			client_command_free(&cmd);
 	}
 	if (!in_io_handler)
 		o_stream_uncork(client->output);