From: Christopher Faulet <cfaulet@haproxy.com>
Date: Tue, 1 Jun 2021 13:54:49 +0000 (+0200)
Subject: MINOR: backend: Don't release SI endpoint anymore in connect_server()
X-Git-Tag: v2.5-dev1~212
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9106d69cb1bc0550ca2f6500ed9a3bcc75d21d6;p=thirdparty%2Fhaproxy.git

MINOR: backend: Don't release SI endpoint anymore in connect_server()

Thanks to the previous patch (822decfd "BUG/MAJOR: stream-int: Release SI
endpoint on server side ASAP on retry"), it is now useless to release any
existing connection in connect_server() because it was already done in
back_handle_st_cer() if necessary.

This patch is not a CLEANUP because it may introduce some bugs in edge
cases. There is no reason to backport it for now except if it is required to
fix a bug.
---

diff --git a/src/backend.c b/src/backend.c
index 0f6b9db3a6..65beb84b76 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -1334,11 +1334,6 @@ int connect_server(struct stream *s)
 
 	hash = conn_calculate_hash(&hash_params);
 
-	/* This will catch some corner cases such as lying connections resulting from
-	 * retries or connect timeouts but will rarely trigger.
-	 */
-	si_release_endpoint(&s->si[1]);
-
 	/* do not reuse if mode is not http */
 	if (!IS_HTX_STRM(s))
 		goto skip_reuse;