From: Michael R Sweet Date: Fri, 13 Dec 2019 14:38:49 +0000 (-0500) Subject: Fix some new compiler warnings (Issue #5700) X-Git-Tag: v2.2.13~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e93ab4a0042242db25ebfbf7cfe99c6932377733;p=thirdparty%2Fcups.git Fix some new compiler warnings (Issue #5700) --- diff --git a/CHANGES.md b/CHANGES.md index 46bd6aa6ae..dc897cc916 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -15,6 +15,7 @@ Changes in CUPS v2.2.13 - Default printers set with `lpoptions` did not work in all cases (Issue #5681, Issue #5683, Issue #5684) - Fixed an off-by-one error in `ippEnumString` (Issue #5695) +- Fixed some new compiler warnings (Issue #5700) - Fixed a few issues with the Apple Raster support (rdar://55301114) - The IPP backend did not detect all cases where a job should be retried using a raster format (rdar://56021091) diff --git a/backend/ipp.c b/backend/ipp.c index 482d6f766e..301e5cefba 100644 --- a/backend/ipp.c +++ b/backend/ipp.c @@ -242,7 +242,6 @@ main(int argc, /* I - Number of command-line args */ int waitjob, /* Wait for job complete? */ waitjob_tries = 0, /* Number of times we've waited */ waitprinter; /* Wait for printer ready? */ - time_t waittime; /* Wait time for held jobs */ _cups_monitor_t monitor; /* Monitoring data */ ipp_attribute_t *job_id_attr; /* job-id attribute */ int job_id; /* job-id value */ @@ -1994,7 +1993,7 @@ main(int argc, /* I - Number of command-line args */ _cupsLangPrintFilter(stderr, "INFO", _("Waiting for job to complete.")); - for (delay = _cupsNextDelay(0, &prev_delay), waittime = time(NULL) + 30; !job_canceled;) + for (delay = _cupsNextDelay(0, &prev_delay); !job_canceled;) { /* * Check for side-channel requests... diff --git a/backend/lpd.c b/backend/lpd.c index accde240de..3bc0e0d15d 100644 --- a/backend/lpd.c +++ b/backend/lpd.c @@ -1056,7 +1056,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send the control file... */ - if (lpd_command(fd, "\002%d cfA%03.3d%.15s\n", (int)strlen(control), + if (lpd_command(fd, "\002%d cfA%03d%.15s\n", (int)strlen(control), (int)getpid() % 1000, localhost)) { close(fd); @@ -1106,7 +1106,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send the print file... */ - if (lpd_command(fd, "\003" CUPS_LLFMT " dfA%03.3d%.15s\n", + if (lpd_command(fd, "\003" CUPS_LLFMT " dfA%03d%.15s\n", CUPS_LLCAST filestats.st_size, (int)getpid() % 1000, localhost)) { @@ -1189,7 +1189,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send control file... */ - if (lpd_command(fd, "\002%d cfA%03.3d%.15s\n", (int)strlen(control), + if (lpd_command(fd, "\002%d cfA%03d%.15s\n", (int)strlen(control), (int)getpid() % 1000, localhost)) { close(fd);