From: Scott O'Hara Date: Tue, 9 Nov 2021 05:54:42 +0000 (-0500) Subject: floating-labels: remove aria-label in the select example (#35327) X-Git-Tag: v5.2.0-beta1~436 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e958cd26371a19df613efce52ecf42c4b0adcddd;p=thirdparty%2Fbootstrap.git floating-labels: remove aria-label in the select example (#35327) While it is understood that this is just an example, the visible text (label) of "Works with selects" and the `aria-label="Floating label select example"` created a [WCAG 2.5.3 Label in name](https://www.w3.org/WAI/WCAG21/quickref/#label-in-name) failure. As the `aria-label` isn't necessary here since this `select` is already provided an accessible name by its `label` element, removing the unnecessary `aria-label` seems the best course of action as: * removing it solves the WCAG issue * it removes the potential implication to developers that they'd even _need_ an `aria-label` here, let alone indirectly suggesting that it's ok for the visible text and accessible name to be out of alignment --- diff --git a/site/content/docs/5.1/forms/floating-labels.md b/site/content/docs/5.1/forms/floating-labels.md index 9410550898..2ac6752047 100644 --- a/site/content/docs/5.1/forms/floating-labels.md +++ b/site/content/docs/5.1/forms/floating-labels.md @@ -89,7 +89,7 @@ When working with the Bootstrap grid system, be sure to place form elements with
-