From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Fri, 25 Oct 2019 15:02:58 +0000 (+0200)
Subject: shared/sleep-config: fix error handling for open
X-Git-Tag: v244-rc1~153^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e97c3691530218c031ef0ab9cb33ca5559270aab;p=thirdparty%2Fsystemd.git

shared/sleep-config: fix error handling for open

CID#1406472.
---

diff --git a/src/shared/sleep-config.c b/src/shared/sleep-config.c
index b5bc6595bd6..3ead397979b 100644
--- a/src/shared/sleep-config.c
+++ b/src/shared/sleep-config.c
@@ -226,11 +226,10 @@ static int calculate_swap_file_offset(const SwapEntry *swap, uint64_t *ret_offse
         assert(streq(swap->type, "file"));
 
         fd = open(swap->device, O_RDONLY|O_CLOEXEC|O_NOCTTY);
-        if (!fd)
+        if (fd < 0)
                 return log_error_errno(errno, "Failed to open %s: %m", swap->device);
 
-        r = fstat(fd, &sb);
-        if (r < 0)
+        if (fstat(fd, &sb) < 0)
                 return log_error_errno(errno, "Failed to stat %s: %m", swap->device);
 
         btrfs = btrfs_is_filesystem(fd);