From: Jouni Malinen Date: Thu, 12 Jun 2014 17:08:00 +0000 (+0300) Subject: dbus: Add explicit break statements to switch-default X-Git-Tag: hostap_2_3~321 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e987c70c85b859fbd9fab6a194579a28f235e3af;p=thirdparty%2Fhostap.git dbus: Add explicit break statements to switch-default There were couple of missing breaks in switch-default (before/after). While these did not have any noticeable issues due to falling over to the next step that just exited from the switch statement, it is cleaner and more robust to have each case use an explicit break. Signed-off-by: Jouni Malinen --- diff --git a/wpa_supplicant/dbus/dbus_dict_helpers.c b/wpa_supplicant/dbus/dbus_dict_helpers.c index 80a1178e2..949ce7c91 100644 --- a/wpa_supplicant/dbus/dbus_dict_helpers.c +++ b/wpa_supplicant/dbus/dbus_dict_helpers.c @@ -934,6 +934,7 @@ static dbus_bool_t _wpa_dbus_dict_entry_get_array( break; case DBUS_TYPE_ARRAY: success = _wpa_dbus_dict_entry_get_binarray(&iter_array, entry); + break; default: break; } diff --git a/wpa_supplicant/dbus/dbus_new_handlers_p2p.c b/wpa_supplicant/dbus/dbus_new_handlers_p2p.c index 8be82888c..af319e6f5 100644 --- a/wpa_supplicant/dbus/dbus_new_handlers_p2p.c +++ b/wpa_supplicant/dbus/dbus_new_handlers_p2p.c @@ -1143,6 +1143,7 @@ dbus_bool_t wpas_dbus_getter_p2p_role(DBusMessageIter *iter, DBusError *error, break; default: str = "device"; + break; } return wpas_dbus_simple_property_getter(iter, DBUS_TYPE_STRING, &str,