From: Jaroslav Kysela <perex@perex.cz>
Date: Fri, 23 Nov 2018 09:38:16 +0000 (+0100)
Subject: spawn: show permissions problem with kill, issue #4774
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9aefbf2c6034c81153a773eaa7d016fa81a8a2f;p=thirdparty%2Ftvheadend.git

spawn: show permissions problem with kill, issue #4774
---

diff --git a/src/spawn.c b/src/spawn.c
index 41b8e1ae4..0e25c4634 100644
--- a/src/spawn.c
+++ b/src/spawn.c
@@ -302,7 +302,9 @@ spawn_reaper(void)
   LIST_FOREACH(s, &spawns, link)
     if (s->killed && s->killed < mclk()) {
       /* kill the whole process group */
-      kill(-(s->pid), SIGKILL);
+      r = kill(-(s->pid), SIGKILL);
+      if (r && errno == EPERM)
+        tvherror(LS_SPAWN, "Unable to kill task pid %d (not enough permissions)", s->pid);
     }
   pthread_mutex_unlock(&spawn_mutex);
 }
@@ -328,8 +330,11 @@ spawn_kill(pid_t pid, int sig, int timeout)
         s->killed = mclk() + sec2mono(MINMAX(timeout, 5, 3600));
       /* kill the whole process group */
       r = kill(-pid, sig);
-      if (r < 0)
+      if (r < 0) {
+        if (errno == EPERM)
+          tvherror(LS_SPAWN, "Unable to kill task pid %d (not enough permissions)", s->pid);
         r = -errno;
+      }
     }
     pthread_mutex_unlock(&spawn_mutex);
   }