From: preed%sigkill.com <>
Date: Sat, 1 Jun 2002 16:33:18 +0000 (+0000)
Subject: Bug 147486 - Fixes cross site scripting issues; first checked in on the 2.14.1 branch... 
X-Git-Tag: bugzilla-2.16rc2~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9b54c9ba4998bd55071e070e0521e6cee5ea9d0;p=thirdparty%2Fbugzilla.git

Bug 147486 - Fixes cross site scripting issues; first checked in on the 2.14.1 branch, but I forgot the 2.16 branch/trunk (thanks bbaetz); patch=preed, r=bbaetz,myk
---

diff --git a/editusers.cgi b/editusers.cgi
index 06c293e2d8..ebc07f2e40 100755
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -343,7 +343,7 @@ if ($action eq 'list') {
             $s = "<STRIKE>";
             $e = "</STRIKE>";
         }
-        $realname ||= "<FONT COLOR=\"red\">missing</FONT>";
+        $realname = ($realname ? html_quote($realname) : "<FONT COLOR=\"red\">missing</FONT>");
         print "<TR>\n";
         print "  <TD VALIGN=\"top\"><A HREF=\"editusers.cgi?action=edit&user=", url_quote($user), "\"><B>$s$user$e</B></A></TD>\n";
         print "  <TD VALIGN=\"top\">$s$realname$e</TD>\n";
@@ -542,7 +542,7 @@ if ($action eq 'del') {
              WHERE login_name=" . SqlQuote($user));
     my ($realname, $groupset) = 
       FetchSQLData();
-    $realname ||= "<FONT COLOR=\"red\">missing</FONT>";
+    $realname = ($realname ? html_quote($realname) : "<FONT COLOR=\"red\">missing</FONT>");
     
     print "<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0>\n";
     print "<TR BGCOLOR=\"#6666FF\">\n";