From: Ondřej Surý <ondrej@sury.org>
Date: Fri, 27 Sep 2019 09:53:49 +0000 (+0200)
Subject: lib/isc/buffer.c: Fix invalid order of DbC checks that could cause dereference before... 
X-Git-Tag: v9.15.6~72^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9f30fc2115524fdef638bc33beaf00a56d27b70;p=thirdparty%2Fbind9.git

lib/isc/buffer.c: Fix invalid order of DbC checks that could cause dereference before NULL check
---

diff --git a/lib/isc/buffer.c b/lib/isc/buffer.c
index 219a5493aba..66defe8bbb8 100644
--- a/lib/isc/buffer.c
+++ b/lib/isc/buffer.c
@@ -550,10 +550,11 @@ isc_buffer_allocate(isc_mem_t *mctx, isc_buffer_t **dynbuffer,
 	bdata = isc_mem_get(mctx, length);
 
 	isc_buffer_init(dbuf, bdata, length);
-	dbuf->mctx = mctx;
 
 	ENSURE(ISC_BUFFER_VALID(dbuf));
 
+	dbuf->mctx = mctx;
+
 	*dynbuffer = dbuf;
 
 	return (ISC_R_SUCCESS);