From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 3 Sep 2024 20:18:18 +0000 (-0400)
Subject: Revert "add test looping over children of a TLV"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9f45f88c36001cf8bb2534068eb8563b2130ba0;p=thirdparty%2Ffreeradius-server.git

Revert "add test looping over children of a TLV"

This reverts commit c105db87995ecee180771bc55f4d43a37efed9bd.

apparently adding local tlvs breaks the wimax tests.

Error : src/tests/keywords/wimax[7]: Failed parsing attribute reference &26.24757.84.9.5.7 - Parent type of nested attribute 26 must be of type "struct", "tlv", "vendor", "vsa" or "group", got "octets"
Error : src/tests/keywords/wimax[7]: &26.24757.84.9.5.7
Error : src/tests/keywords/wimax[7]:     ^

arguably the error is correct.  but in the interest of making CI
pass, and not annoying others, we just disable the failing test
for now
---

diff --git a/src/tests/keywords/foreach-tlv-children b/src/tests/keywords/foreach-tlv-children
deleted file mode 100644
index 44f8b27a04..0000000000
--- a/src/tests/keywords/foreach-tlv-children
+++ /dev/null
@@ -1,37 +0,0 @@
-#
-#  PRE: foreach
-#
-#  Loop over children of a TLV.
-#
-#  Note that the only data types compatible with all data types are "string" or "octets"
-#
-string out
-
-&my-tlv := {
-	&a = 1
-	&b = 2
-	&c = "foo"
-	&d = 127.0.0.1
-}
-
-
-&out = ""
-
-#
-#  Home-brew concat!
-#
-foreach string child (&my-tlv.[*]) {
-	&out += &child
-	&out += " "
-}
-
-#
-#  Sad trailing space, but we can delete it!
-#
-&out -= ' '
-
-if (&out != '1 2 foo 127.0.0.1') {
-	test_fail
-}
-
-success
diff --git a/src/tests/keywords/radius.conf b/src/tests/keywords/radius.conf
index 3fc1e844b0..0b21970280 100644
--- a/src/tests/keywords/radius.conf
+++ b/src/tests/keywords/radius.conf
@@ -135,15 +135,6 @@ server default {
 		type = Access-Request
 	}
 
-	dictionary {
-		tlv my-tlv {
-			uint32 a
-			uint32 b
-			string c
-			ipaddr d
-		}
-	}
-
 	recv Access-Request {
 		&control.Password.Cleartext := "hello"