From: Eric Wong <e@80x24.org>
Date: Sun, 23 Aug 2015 19:04:21 +0000 (+0000)
Subject: cleanup Email::Address usage
X-Git-Tag: v1.0.0~993
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9fda329d958fca206543b92bc8ebea8e91eb43a;p=thirdparty%2Fpublic-inbox.git

cleanup Email::Address usage

Email::Address::name never fails assuming it was able to parse
anything.
---

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 51216aaa1..f4d19e020 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -279,7 +279,7 @@ sub add_to_feed {
 	my $type = index($title, '&') >= 0 ? "\ntype=\"html\"" : '';
 
 	my $from = mime_header($header_obj, 'From') or return 0;
-	my @from = Email::Address->parse($from);
+	my @from = Email::Address->parse($from) or return 0;
 	my $name = PublicInbox::Hval->new_oneline($from[0]->name)->as_html;
 	my $email = $from[0]->address;
 	$email = PublicInbox::Hval->new_oneline($email)->as_html;
diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
index fe04ded9e..16da7afac 100644
--- a/lib/PublicInbox/MDA.pm
+++ b/lib/PublicInbox/MDA.pm
@@ -88,9 +88,7 @@ sub author_info {
 	my $from = $mime->header('From');
 	my @from = Email::Address->parse($from);
 	my $name = $from[0]->name;
-	defined $name or $name = '';
 	my $email = $from[0]->address;
-	defined $email or $email = '';
 	($name, $email, $mime->header('Date'));
 }
 
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index fe37a9fc6..f4e728269 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -65,7 +65,6 @@ sub index_entry {
 	my $from = PublicInbox::Hval->new_oneline($mime->header('From'))->raw;
 	my @from = Email::Address->parse($from);
 	$from = $from[0]->name;
-	(defined($from) && length($from)) or $from = $from[0]->address;
 
 	$from = PublicInbox::Hval->new_oneline($from)->as_html;
 	$subj = PublicInbox::Hval->new_oneline($subj)->as_html;