From: Florian Forster <octo@collectd.org>
Date: Thu, 23 Nov 2023 13:58:54 +0000 (+0100)
Subject: GitHub actions: continue on error and upload test logs.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea10acee7adc62f5aa3b93f2fd428233bca4b296;p=thirdparty%2Fcollectd.git

GitHub actions: continue on error and upload test logs.

When `make check` fails, continue so that the "upload logs" step is
performed. Use the `upload-artifact` action instead of just `cat`ing the
file.
---

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 46438a761..cf9d17aa9 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -59,9 +59,12 @@ jobs:
       run: make $MAKEFLAGS
     - name: Run make check
       run: make $MAKEFLAGS check
+      continue-on-error: true
     - name: Dump test logs
-      run: |
-          cat ./test-suite.log || true
+      uses: actions/upload-artifact@v3
+      with:
+        name: Test suite log
+        path: test-suite.log
     - name: Install bzip2
       run: |
         yum install -y bzip2 || apt install -y bzip2
@@ -106,12 +109,13 @@ jobs:
     - name: Build collectd
       run: make $MAKEFLAGS
     - name: Run make check
-      # Make check is failing on a few newer distros, temporarily mark it as optional until that is resolved 
-      continue-on-error: true
       run: make $MAKEFLAGS check
+      continue-on-error: true
     - name: Dump test logs
-      run: |
-          cat ./test-suite.log || true
+      uses: actions/upload-artifact@v3
+      with:
+        name: Test suite log
+        path: test-suite.log
     - name: Install bzip2
       run: |
         yum install -y bzip2 || apt install -y bzip2