From: Mark Andrews <marka@isc.org>
Date: Fri, 19 Aug 2022 01:13:59 +0000 (+1000)
Subject: Silence negative array index warning with toupper
X-Git-Tag: v9.19.5~29^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea13820023b85f1b8989d006e0c12a9490d2d5dc;p=thirdparty%2Fbind9.git

Silence negative array index warning with toupper

Cast to (unsigned char).
---

diff --git a/lib/isccfg/duration.c b/lib/isccfg/duration.c
index 27dddca1cc2..305047e1af1 100644
--- a/lib/isccfg/duration.c
+++ b/lib/isccfg/duration.c
@@ -63,7 +63,7 @@ isccfg_duration_fromtext(isc_textregion_t *source,
 	duration->unlimited = false;
 
 	/* Every duration starts with 'P' */
-	if (toupper(str[0]) != 'P') {
+	if (toupper((unsigned char)str[0]) != 'P') {
 		return (ISC_R_BADNUMBER);
 	}
 	P = str;