From: Eric Wong <e@80x24.org>
Date: Fri, 10 Jan 2025 23:19:04 +0000 (+0000)
Subject: extindex: eliminate repeated ->eidx_key method call
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea258ad64c506324742e619414e46abf5554e9df;p=thirdparty%2Fpublic-inbox.git

extindex: eliminate repeated ->eidx_key method call

No need to make two relatively expensive `->' method calls when
one will do.
---

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 76699c6b3..6693542b6 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -254,8 +254,8 @@ sub index_unseen ($) {
 	$self->{oidx}->add_overview($eml, $new_smsg);
 	my $oid = $new_smsg->{blob};
 	my $ibx = delete $req->{ibx} or die 'BUG: {ibx} unset';
-	$self->{oidx}->add_xref3($docid, $req->{xnum}, $oid, $ibx->eidx_key);
-	$new_smsg->{eidx_key} = $ibx->eidx_key;
+	my $ekey = $new_smsg->{eidx_key} = $ibx->eidx_key;
+	$self->{oidx}->add_xref3($docid, $req->{xnum}, $oid, $ekey);
 	$idx->index_eml($eml, $new_smsg);
 	update_checkpoint $self, $new_smsg->{bytes};
 }