From: Johan Hovold Date: Tue, 12 Jan 2016 11:05:20 +0000 (+0100) Subject: USB: visor: fix null-deref at probe X-Git-Tag: v2.6.32.71~53 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea26131ff39cf3517a784672368ad17fbdeba5eb;p=thirdparty%2Fkernel%2Fstable.git USB: visor: fix null-deref at probe commit cac9b50b0d75a1d50d6c056ff65c005f3224c8e0 upstream. Fix null-pointer dereference at probe should a (malicious) Treo device lack the expected endpoints. Specifically, the Treo port-setup hack was dereferencing the bulk-in and interrupt-in urbs without first making sure they had been allocated by core. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold Signed-off-by: Ben Hutchings Signed-off-by: Willy Tarreau --- diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c index e9229c528ad1d..741d834647a9d 100644 --- a/drivers/usb/serial/visor.c +++ b/drivers/usb/serial/visor.c @@ -878,6 +878,11 @@ static int treo_attach(struct usb_serial *serial) dbg("%s", __func__); + if (serial->num_bulk_in < 2 || serial->num_interrupt_in < 2) { + dev_err(&serial->interface->dev, "missing endpoints\n"); + return -ENODEV; + } + /* * It appears that Treos and Kyoceras want to use the * 1st bulk in endpoint to communicate with the 2nd bulk out endpoint,