From: Jonatan Schlag <jonatan.schlag@ipfire.org>
Date: Wed, 5 Jul 2017 14:19:53 +0000 (+0200)
Subject: zone: Check early if a id is valid
X-Git-Tag: 009~186
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea37ec0b3e9ed64417c425c8ded352512b9895f0;p=network.git

zone: Check early if a id is valid

Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/functions/functions.zone b/src/functions/functions.zone
index 776b63b0..d1212252 100644
--- a/src/functions/functions.zone
+++ b/src/functions/functions.zone
@@ -550,7 +550,12 @@ zone_config() {
 			zone_config_new "${zone}" "$@"
 			;;
 		destroy)
-			zone_config_destroy "${zone}" "$@"
+			local id=${1}
+			if zone_config_id_is_valid ${zone} ${id}; then
+				zone_config_destroy "${zone}" "$@"
+			else
+				log ERROR "${id} is not a valid id"
+			fi
 			;;
 		edit)
 			zone_config_edit "${zone}" "$@"