From: Douglas Bagnall Date: Fri, 3 May 2019 05:27:51 +0000 (+1200) Subject: CVE-2019-14847 dsdb/modules/dirsync: ensure attrs exist (CID 1107212) X-Git-Tag: samba-4.9.15~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea39bdd6293041af668f1bfdfea39a725733bad3;p=thirdparty%2Fsamba.git CVE-2019-14847 dsdb/modules/dirsync: ensure attrs exist (CID 1107212) BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040 Signed-off-by: Douglas Bagnall Reviewed-by: Gary Lockyer (cherry picked from commit 23f72c4d712f8d1fec3d67a66d477709d5b0abe2) --- diff --git a/source4/dsdb/samdb/ldb_modules/dirsync.c b/source4/dsdb/samdb/ldb_modules/dirsync.c index b5510eccd24..62a66fef8d4 100644 --- a/source4/dsdb/samdb/ldb_modules/dirsync.c +++ b/source4/dsdb/samdb/ldb_modules/dirsync.c @@ -343,6 +343,10 @@ skip: attr = dsdb_attribute_by_lDAPDisplayName(dsc->schema, el->name); + if (attr == NULL) { + continue; + } + keep = false; if (attr->linkID & 1) {