From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 23 Jan 2020 14:19:58 +0000 (+0100)
Subject: modules/renumber: don't accidentally zero-out .state
X-Git-Tag: v5.0.0~2^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea414ce92b3c4f545458387e9bedecbb59012c90;p=thirdparty%2Fknot-resolver.git

modules/renumber: don't accidentally zero-out .state

It was possible for some failures to disappear that way.
---

diff --git a/NEWS b/NEWS
index 46f5db954..7e5cc9406 100644
--- a/NEWS
+++ b/NEWS
@@ -15,11 +15,13 @@ Improvements
 - lua: remove dependency on lua-socket and lua-sec, used lua-http and cqueues (#512, #521, !894)
 - net.listen(): allow binding to non-local address with freebind option (!898)
 - cache: pre-allocate the file to avoid SIGBUS later (not macOS; !917, #525)
+- lua: be stricter around nonsense returned from modules (!901)
 
 Bugfixes
 --------
 - correctly use EDNS(0) padding in failed answers (!921)
 - policy and daf modules: fix reroute rules (!901)
+- renumber module: don't accidentally zero-out request's .state (!901)
 
 
 Knot Resolver 4.3.0 (2019-12-04)
diff --git a/modules/renumber/renumber.lua b/modules/renumber/renumber.lua
index 3e934dfce..8512093ab 100644
--- a/modules/renumber/renumber.lua
+++ b/modules/renumber/renumber.lua
@@ -82,7 +82,7 @@ local function rule(prefixes)
 			end
 		end
 		-- If not rewritten, chain action
-		if not changed then return end
+		if not changed then return state end
 		-- Replace section if renumbering
 		local qname = pkt:qname()
 		local qclass = pkt:qclass()