From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Thu, 9 Jun 2022 14:57:26 +0000 (-0700)
Subject: Remove a redundant subexpression that was always true.
X-Git-Tag: 4.1-rc1~24^2~144
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea4eafbfedfd0d777f6329d3e5543c3fa86bd9e8;p=thirdparty%2Fshairport-sync.git

Remove a redundant subexpression that was always true.
---

diff --git a/dacp.c b/dacp.c
index 8bacf3d7..1355fdc6 100644
--- a/dacp.c
+++ b/dacp.c
@@ -562,7 +562,7 @@ void *dacp_monitor_thread_code(__attribute__((unused)) void *na) {
     pthread_cleanup_pop(1);
 
     if (result == 490) { // 490 means no port was specified
-      if (((char *)dacp_server.dacp_id != NULL) && (strlen(dacp_server.dacp_id) != 0)) {
+      if (strlen(dacp_server.dacp_id) != 0) {
         // debug(1,"mdns_dacp_monitor_set_id");
         mdns_dacp_monitor_set_id(dacp_server.dacp_id);
       }