From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 3 Aug 2023 08:30:12 +0000 (+0200)
Subject: virfirewalld: Drop useless memset() in virFirewallDApplyRule()
X-Git-Tag: v9.7.0-rc1~164
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea5352334af4ce9151e826db7a0dc3f02a211b6c;p=thirdparty%2Flibvirt.git

virfirewalld: Drop useless memset() in virFirewallDApplyRule()

This is a residue of v6.8.0-rc1~100. The error variable inside of
virFirewallDApplyRule() is already initialized to NULL. There's
no need to memset() it to zero again.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
---

diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c
index 6fc54f357d..827e201dbb 100644
--- a/src/util/virfirewalld.c
+++ b/src/util/virfirewalld.c
@@ -360,8 +360,6 @@ virFirewallDApplyRule(virFirewallLayer layer,
     if (!sysbus)
         return -1;
 
-    memset(&error, 0, sizeof(error));
-
     if (!ipv) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("Unknown firewall layer %1$d"),