From: mkanat%bugzilla.org <>
Date: Fri, 1 Aug 2008 05:07:42 +0000 (+0000)
Subject: Bug 448614: [Oracle] Logic error in _get_alter_type_sql
X-Git-Tag: bugzilla-3.2rc1~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea8a7a5d2c62f2f1df259de01d88886376a17246;p=thirdparty%2Fbugzilla.git

Bug 448614: [Oracle] Logic error in _get_alter_type_sql
Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat
---

diff --git a/Bugzilla/DB/Schema/Oracle.pm b/Bugzilla/DB/Schema/Oracle.pm
index 6b6fa5c576..05c2bbeb3b 100644
--- a/Bugzilla/DB/Schema/Oracle.pm
+++ b/Bugzilla/DB/Schema/Oracle.pm
@@ -322,7 +322,7 @@ sub _get_alter_type_sql {
     } 
     # If this column is no longer TEXT/VARCHAR, we need to drop the trigger
     # that went along with it.
-    if ( $old_def->{TYPE} !~ /varchar|text/i
+    if ( $old_def->{TYPE} =~ /varchar|text/i
             && $old_def->{NOTNULL}
             && $new_def->{TYPE} !~ /varchar|text/i )
     {