From: Benjamin Dopplinger <b.dopplinger@gmail.com>
Date: Thu, 10 Nov 2016 16:15:37 +0000 (-0500)
Subject: Remove non-working Connection.default_schema_name() method
X-Git-Tag: rel_1_1_4~11^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ea934b95396d4796ceee8ae949a964a4d3005211;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Remove non-working Connection.default_schema_name() method

The method `engine.base.Connection.default_schema_name` is broken since
4b532e2 (this was when `engine.dialect.get_default_schema_name` was
replaced with `engine.dialect.default_schema_name`).  The method is
unused and also is not functional for end-user use, so remove it
for now.

Change-Id: I6ffbd9ce1b9b54ff6df63ed45d7d33591f183933
Pull-request: https://github.com/zzzeek/sqlalchemy/pull/321
---

diff --git a/doc/build/changelog/changelog_11.rst b/doc/build/changelog/changelog_11.rst
index 4c8bdc7d96..09cd9c4c43 100644
--- a/doc/build/changelog/changelog_11.rst
+++ b/doc/build/changelog/changelog_11.rst
@@ -21,6 +21,14 @@
 .. changelog::
     :version: 1.1.4
 
+    .. change::
+        :tags: bug, engine
+
+        Removed long-broken "default_schema_name()" method from
+        :class:`.Connection`.  This method was left over from a very old
+        version and was non-working (e.g. would raise).  Pull request
+        courtesy Benjamin Dopplinger.
+
     .. change::
         :tags: bug, sqlite
 
diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py
index 1d23c66b3c..8385686056 100644
--- a/lib/sqlalchemy/engine/base.py
+++ b/lib/sqlalchemy/engine/base.py
@@ -1458,9 +1458,6 @@ class Connection(Connectable):
         else:
             util.reraise(*exc_info)
 
-    def default_schema_name(self):
-        return self.engine.dialect.get_default_schema_name(self)
-
     def transaction(self, callable_, *args, **kwargs):
         """Execute the given function within a transaction boundary.