From: Martti Rannanjärvi <martti.rannanjarvi@dovecot.fi>
Date: Wed, 29 Aug 2018 10:40:33 +0000 (+0300)
Subject: lib-dns: Set error_r in dns_client_connect() on failure
X-Git-Tag: 2.3.9~1502
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eab25e21bac9f860777c1b6628714ab8c2e65ae8;p=thirdparty%2Fdovecot%2Fcore.git

lib-dns: Set error_r in dns_client_connect() on failure
---

diff --git a/src/lib-dns/dns-lookup.c b/src/lib-dns/dns-lookup.c
index 2c134a2727..7fcf970198 100644
--- a/src/lib-dns/dns-lookup.c
+++ b/src/lib-dns/dns-lookup.c
@@ -321,7 +321,7 @@ void dns_client_deinit(struct dns_client **_client)
 	i_free(client);
 }
 
-int dns_client_connect(struct dns_client *client, const char **error_r ATTR_UNUSED)
+int dns_client_connect(struct dns_client *client, const char **error_r)
 {
 	if (client->connected)
 		return 0;
@@ -329,7 +329,11 @@ int dns_client_connect(struct dns_client *client, const char **error_r ATTR_UNUS
 	connection_init_client_unix(client->clist, &client->conn, client->path);
 	if (client->ioloop != NULL)
 		connection_switch_ioloop_to(&client->conn, client->ioloop);
-	return connection_client_connect(&client->conn);
+	int ret = connection_client_connect(&client->conn);
+	if (ret < 0)
+		*error_r = t_strdup_printf("Failed to connect to %s: %m",
+					   client->path);
+	return ret;
 }
 
 static int