From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Thu, 15 Jan 2026 08:28:18 +0000 (+0100)
Subject: yparser: every IPv6 address contains at least 2 colons
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eab5ebc662c8c104337f3a4b69c0d3f81da7a212;p=thirdparty%2Fknot-dns.git

yparser: every IPv6 address contains at least 2 colons

This fixes issues with UNIX socket paths containing a colon.
---

diff --git a/src/libknot/yparser/yptrafo.c b/src/libknot/yparser/yptrafo.c
index 30321164f3..ff02cd7551 100644
--- a/src/libknot/yparser/yptrafo.c
+++ b/src/libknot/yparser/yptrafo.c
@@ -384,25 +384,25 @@ static uint8_t sock_type_guess(
 	const uint8_t **if_name)
 {
 	size_t dots = 0;
-	size_t semicolons = 0;
+	size_t colons = 0;
 	size_t digits = 0;
 
 	// Analyze the string.
 	for (size_t i = 0; i < len; i++) {
 		if (str[i] == '.') dots++;
-		else if (str[i] == ':') semicolons++;
+		else if (str[i] == ':') colons++;
 		else if (is_digit(str[i])) digits++;
 	}
 
 	// Guess socket type.
-	if (semicolons >= 1) {
+	if (colons >= 2) {
 		*if_name = (const uint8_t *)strchr((const char *)str, '%');
 		if (*if_name == NULL) {
 			return ADDR_TYPE_IPV6;
 		} else {
 			return ADDR_TYPE_IPV6_LINKLOCAL;
 		}
-	} else if (semicolons == 0 && dots == 3 && digits >= 3) {
+	} else if (colons == 0 && dots == 3 && digits >= 3) {
 		return ADDR_TYPE_IPV4;
 	} else {
 		return ADDR_TYPE_UNIX;