From: Victor Julien <victor@inliniac.net>
Date: Tue, 23 Oct 2018 12:29:59 +0000 (+0200)
Subject: bits: avoid memory leak in case of adding types
X-Git-Tag: suricata-4.0.6~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ead1e9830b3173e7d218f5618d76b0550c00ff6a;p=thirdparty%2Fsuricata.git

bits: avoid memory leak in case of adding types
---

diff --git a/src/detect-flowbits.c b/src/detect-flowbits.c
index 56abce0bfc..45b5c4ac00 100644
--- a/src/detect-flowbits.c
+++ b/src/detect-flowbits.c
@@ -276,6 +276,9 @@ int DetectFlowbitSetup (DetectEngineCtx *de_ctx, Signature *s, const char *rawst
             /* modifiers, only run when entire sig has matched */
             SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_POSTMATCH);
             break;
+
+        default:
+            goto error;
     }
 
     return 0;
diff --git a/src/detect-hostbits.c b/src/detect-hostbits.c
index addca7c374..ad352d0a00 100644
--- a/src/detect-hostbits.c
+++ b/src/detect-hostbits.c
@@ -418,6 +418,9 @@ int DetectHostbitSetup (DetectEngineCtx *de_ctx, Signature *s, const char *rawst
             /* modifiers, only run when entire sig has matched */
             SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_POSTMATCH);
             break;
+
+        default:
+            goto error;
     }
 
     return 0;