From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Tue, 21 Oct 2025 16:08:28 +0000 (+0100)
Subject: i2c: npcm: Fix error detection
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb13583b9de27005703ab085d5ef45fcdbb1d4fb;p=thirdparty%2Fu-boot.git

i2c: npcm: Fix error detection

Testing an unisgned member of a struct to be <= 0 will only detect the
case when it is 0. So correct this error test to a working version that
will behave as expected.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Heiko Schocher <hs@nabladev.com>
---

diff --git a/drivers/i2c/npcm_i2c.c b/drivers/i2c/npcm_i2c.c
index bff0d04f1a5..d57237a6df1 100644
--- a/drivers/i2c/npcm_i2c.c
+++ b/drivers/i2c/npcm_i2c.c
@@ -573,7 +573,7 @@ static int npcm_i2c_probe(struct udevice *dev)
 		return ret;
 	}
 	bus->apb_clk = clk_get_rate(&clk);
-	if (bus->apb_clk <= 0) {
+	if (!bus->apb_clk || IS_ERR_VALUE(bus->apb_clk)) {
 		printf("%s: fail to get rate\n", __func__);
 		return -EINVAL;
 	}