From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sun, 16 Feb 2025 21:04:46 +0000 (+0900)
Subject: network/address: update comment
X-Git-Tag: v258-rc1~1307^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb381e65f1dbdb17a7d76f1850fcacfea4b329d1;p=thirdparty%2Fsystemd.git

network/address: update comment

As commented in the code, the check is now redundant. But let's keep
that to make IPv6LL addresses on other interfaces not removed
accidentally.
---

diff --git a/src/network/networkd-address.c b/src/network/networkd-address.c
index 3857aad047e..d35d2ed521e 100644
--- a/src/network/networkd-address.c
+++ b/src/network/networkd-address.c
@@ -1338,8 +1338,8 @@ int link_drop_ipv6ll_addresses(Link *link) {
                 struct in6_addr address;
                 int ifindex;
 
-                /* NETLINK_GET_STRICT_CHK socket option is supported since kernel 4.20. To support
-                 * older kernels, we need to check ifindex here. */
+                /* We set ifindex in the request, and NETLINK_GET_STRICT_CHK socket option is set. Hence the
+                 * check below is redundant, but let's do that for safety. */
                 r = sd_rtnl_message_addr_get_ifindex(addr, &ifindex);
                 if (r < 0) {
                         log_link_debug_errno(link, r, "rtnl: received address message without valid ifindex, ignoring: %m");