From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Mon, 20 Feb 2023 09:27:44 +0000 (-0800)
Subject: Fix inherited permissions being set at user level & unable to unselect existing perms
X-Git-Tag: v1.14.0-beta.rc1~91^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb4c8e1b1e24facf0cb57ed24f8b06315549fc0d;p=thirdparty%2Fpaperless-ngx.git

Fix inherited permissions being set at user level & unable to unselect existing perms
---

diff --git a/src-ui/src/app/components/common/permissions-select/permissions-select.component.ts b/src-ui/src/app/components/common/permissions-select/permissions-select.component.ts
index 74e8a73c4f..fa97a3b558 100644
--- a/src-ui/src/app/components/common/permissions-select/permissions-select.component.ts
+++ b/src-ui/src/app/components/common/permissions-select/permissions-select.component.ts
@@ -69,6 +69,10 @@ export class PermissionsSelectComponent
   }
 
   writeValue(permissions: string[]): void {
+    if (this.permissions === permissions) {
+      return
+    }
+
     this.permissions = permissions ?? []
     const allPerms = this._inheritedPermissions.concat(this.permissions)
 
@@ -138,7 +142,10 @@ export class PermissionsSelectComponent
           this.typesWithAllActions.delete(typeKey)
         }
       })
-      this.onChange(permissions)
+
+      this.onChange(
+        permissions.filter((p) => !this._inheritedPermissions.includes(p))
+      )
     })
   }