From: Francois Berder <fberder@outlook.fr>
Date: Tue, 2 Dec 2025 18:39:39 +0000 (+0100)
Subject: pinctrl: single: Add missing free in single_allocate_function
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb52d3fe8a591d6daf6d01570ed19ae88b1e934d;p=thirdparty%2Fu-boot.git

pinctrl: single: Add missing free in single_allocate_function

If func->pins could not be allocated, one must also free
func variable that was allocated previously.

Signed-off-by: Francois Berder <fberder@outlook.fr>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
---

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index c96b293aadf..42980e097e0 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -282,8 +282,10 @@ static struct single_func *single_allocate_function(struct udevice *dev,
 
 	func->pins = devm_kmalloc(dev, sizeof(unsigned int) * group_pins,
 				  GFP_KERNEL);
-	if (!func->pins)
+	if (!func->pins) {
+		devm_kfree(dev, func);
 		return ERR_PTR(-ENOMEM);
+	}
 
 	return func;
 }